Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unsafe wrapping should only happen for with_ loops #64401

Merged
merged 5 commits into from
Nov 6, 2019
Merged

unsafe wrapping should only happen for with_ loops #64401

merged 5 commits into from
Nov 6, 2019

Conversation

sivel
Copy link
Member

@sivel sivel commented Nov 4, 2019

SUMMARY

unsafe wrapping should only happen for with_ lookp. Fixes #64379. Addresses #64169

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/executor/task_executor.py

ADDITIONAL INFORMATION

cc @geerlingguy

@sivel sivel requested review from bcoca and mkrizek November 4, 2019 17:34
@ansibot
Copy link
Contributor

ansibot commented Nov 4, 2019

cc @acozine
click here for bot help

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Nov 4, 2019
@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Nov 5, 2019
@tremble tremble mentioned this pull request Nov 5, 2019
Closed
@sivel sivel requested a review from acozine November 5, 2019 17:11
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Nov 5, 2019
sivel and others added 2 commits November 5, 2019 14:09
@sivel @samccann
typo
18bb777 
Co-Authored-By: Sandra McCann <samccann@redhat.com>
@sivel @samccann
punctuation
0d76ddb 
Co-Authored-By: Sandra McCann <samccann@redhat.com>
acozine
acozine approved these changes Nov 5, 2019
View reviewed changes
Copy link
Contributor

@acozine acozine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With edits from ce54786, the PR looks good.

@sivel sivel merged commit 254788b into ansible:devel Nov 6, 2019
sivel added a commit to sivel/ansible that referenced this pull request Nov 6, 2019
@sivel
[stable-2.9] unsafe wrapping should only happen for with_ loops (ansi…
a155896 
…ble#64401)

* unsafe wrapping should only happen for with_ lookups. Fixes ansible#64379. Addresses ansible#64169

* edit porting guide entry

* typo in changelog fragment

* typo

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* punctuation

Co-Authored-By: Sandra McCann <samccann@redhat.com>
(cherry picked from commit 254788b)

Co-authored-by: Matt Martz <matt@sivel.net>
@sivel sivel mentioned this pull request Nov 11, 2019
Merged
mattclay pushed a commit that referenced this pull request Nov 12, 2019
@sivel @mattclay
[stable-2.9] unsafe wrapping should only happen for with_ loops (#64401)
26e8474 
* unsafe wrapping should only happen for with_ lookups. Fixes #64379. Addresses #64169

* edit porting guide entry

* typo in changelog fragment

* typo

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* punctuation

Co-Authored-By: Sandra McCann <samccann@redhat.com>
(cherry picked from commit 254788b)

Co-authored-by: Matt Martz <matt@sivel.net>
@ansible ansible locked and limited conversation to collaborators Dec 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samccann samccann samccann left review comments

@acozine acozine acozine approved these changes

@mkrizek mkrizek mkrizek approved these changes

@bcoca bcoca Awaiting requested review from bcoca

Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. docs This issue/PR relates to or includes documentation. has_issue needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[2.9] Iterating over a list of hashes with variables doesn't work
5 participants
@sivel @ansibot @acozine @mkrizek @samccann